directivity plot: fixes and improvements #252

Merged
emolch merged 1 commits from improve-directivity-plot into master 3 weeks ago
emolch commented 1 month ago
Owner
  • fix ignored quantity param
  • fix color scale range problem
  • add interpolation param to set GF interpolation methd
  • add target_depth param to set receiver depth
  • changed waveform processing to prevent demeaning of traces
  • changed waveform processing to not do bandpass but separate high and low
  • docs: add simple analytical radiation pattern example
  • fix typos
- fix ignored `quantity` param - fix color scale range problem - add `interpolation` param to set GF interpolation methd - add `target_depth` param to set receiver depth - changed waveform processing to prevent demeaning of traces - changed waveform processing to not do bandpass but separate high and low - docs: add simple analytical radiation pattern example - fix typos
emolch added 1 commit 1 month ago
df1f097b8b directivity plot: fixes and improvements
emolch requested review from miili 1 month ago
emolch added the
Need Review
label 1 month ago
miili requested changes 1 month ago
miili left a comment

Great, thanks for the work!

engine = LocalEngine(store_dirs=[store_path])
# import matplotlib.pyplot as plt
miili commented 1 month ago
Poster
Owner

Remove commented lines.

Remove commented lines.
emolch commented 1 month ago
Poster
Owner

I'd like to keep these so that we (and users) can more easily export the figures. Also in case we have to recreate the doc figures at the same size after an update. As this is a more advanced plot I think we can go a bit longer in the examples.

I'd like to keep these so that we (and users) can more easily export the figures. Also in case we have to recreate the doc figures at the same size after an update. As this is a more advanced plot I think we can go a bit longer in the examples.
miili commented 1 month ago
Poster
Owner

alrighty.

alrighty.
miili marked this conversation as resolved
assert hasattr(target, 'azimuth')
assert target.dazi
miili commented 1 month ago
Poster
Owner

No asserts in production, raise AttributeError or ValueError

No asserts in production, raise `AttributeError` or `ValueError`
emolch commented 1 month ago
Poster
Owner

In my opinion it is ok to keep some asserts where they only catch programmer errors. I did not add the asserts in plot_directivity, could you check which ones catch programmer and which ones user errors?

In my opinion it is ok to keep some asserts where they only catch programmer errors. I did not add the asserts in `plot_directivity`, could you check which ones catch programmer and which ones user errors?
miili commented 1 month ago
Poster
Owner

Fine with me.

Fine with me.
miili marked this conversation as resolved
emolch force-pushed improve-directivity-plot from df1f097b8b to 33788f3168 1 month ago
miili force-pushed improve-directivity-plot from 33788f3168 to 157cce5f0f 1 month ago
miili added
Ready
and removed
Need Review
labels 1 month ago
miili force-pushed improve-directivity-plot from 157cce5f0f to 625ef5f8ef 1 month ago
emolch force-pushed improve-directivity-plot from 625ef5f8ef to c47e40450d 3 weeks ago
emolch merged commit c47e40450d into master 3 weeks ago
emolch deleted branch improve-directivity-plot 3 weeks ago

Reviewers

miili requested changes 1 month ago
continuous-integration/drone/push Build is failing
The pull request has been merged as c47e40450d.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.