Marius Kriegerowski HerrMuellerluedenscheid
  • Joined on Feb 07, 2019
Loading Heatmap…

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

> But what if salami is added at run-time to the module? > pylint check can be disabled in `.pylintrc` or within code: ``` import pyrocko a = pyrocko.util.salami()

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

Since guido brought this up in that twitter post: I started using type hints a lot which play super nicely with many IDEs. And mypy. But let's disucss this another time :)

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

Maybe I don't know about the member test of flake8 though.

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

> To add another quote by Guido > > > You missed mypy. Simpler docs use markdown, not ReST (Sphinx). Black is overrated unless your team argues over style a lot. **You don't need Pylint if you're…

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

> Why not train a NN with the current codebase? Should be enough training data. > Well, actually I think there is some plugin that does exactly that. I remember receiving some ad.

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

I think the level to which the bracked belongs is crystal clear when it is given that extra space.

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

> `black --line-length=80`: > > ``` > > descr = [ > - prop.classname_for_help(strip_module=cls.dummy_cls.__module__)] > + …

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

`black --line-length=80`: ``` descr = [ - prop.classname_for_help(strip_module=cls.dummy_cls.__module__)] + …

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

Can I get your intelli-brain(TM) as plugin for my editor? I hope it's documented. pyrocko uses (1), I would probably have used (3) as I find it actually quite good to read given the nested nature…

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

... and if I find it hard to read what black suggested I should probably disassemble the line and come up with a more readable flow. > I don't know. Maybe there is a "soft" way of…

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

Let me give you an example (not my code just an example from pyrocko after curiously running black on pyrocko). I would probably have spent quite some time thinking about which version I would have…

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

Guilty as charged :)

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

So, I guess I can close the issue?

9 months ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#129

Enforce strict linting

The upper looks really strange to me. I wanna say uggly. Now. :)

9 months ago

HerrMuellerlueden... opened issue pyrocko/pyrocko#129

Enforce strict linting

9 months ago

HerrMuellerlueden... pushed to marker-table-explicify at pyrocko/pyrocko

  • f6e6a3e103 marker_editor: Dont abbreviate phase and event

12 months ago

HerrMuellerlueden... opened issue pyrocko/contrib-snufflings#4

ahfullgreen fails to import from non-master branch

1 year ago

HerrMuellerlueden... commented on issue pyrocko/pyrocko#91

Help function broken

cgi.escape is deprecated (py3) and removed since python3.8. Resolved in commit #1b3835ab9e

1 year ago

HerrMuellerlueden... created pull request pyrocko/pyrocko#99

use html.escape over cgi.escpe in py3 (deprecated)

1 year ago

HerrMuellerlueden... pushed to fix-py38-compatibility at pyrocko/pyrocko

  • 1b3835ab9e use html.escape over cgi.escpe in py3 (deprecated)

1 year ago